Skip to content

rename tests#1007

Merged
jan-janssen merged 3 commits into
mainfrom
rename_tests
Jun 10, 2026
Merged

rename tests#1007
jan-janssen merged 3 commits into
mainfrom
rename_tests

Conversation

@jan-janssen

@jan-janssen jan-janssen commented Jun 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Renamed and reorganized many test methods and test classes across benchmark, unit, and interactive suites for clearer, scheduler-focused naming (e.g., block-allocation vs one-process scenarios).
    • Updated test names to better describe scenarios like timing benchmarks, single-task submission, MPI vs non-MPI flows, caching, and serial vs multi-core runs.
    • No test logic or behavior was changed.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@jan-janssen, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 31 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 76e3d78d-0c08-43ac-b77e-dd6e4ed269bd

📥 Commits

Reviewing files that changed from the base of the PR and between ee980a6 and acc6a24.

📒 Files selected for processing (5)
  • tests/unit/executor/test_single_dependencies.py
  • tests/unit/executor/test_single_mpi.py
  • tests/unit/executor/test_single_noblock.py
  • tests/unit/standalone/interactive/test_communication.py
  • tests/unit/task_scheduler/file/test_serial.py
📝 Walkthrough

Walkthrough

Test methods across the executor and scheduler test suites were renamed to clearer, scenario-specific identifiers. Scheduler info tests were updated to assert scheduler-specific metadata fields (BlockAllocationTaskScheduler.info and OneProcessTaskScheduler.info).

Changes

Test Clarity Improvements

Layer / File(s) Summary
Executor & benchmark test method renames
tests/benchmark/test_results.py, tests/unit/executor/test_api.py, tests/unit/executor/test_single_mpi.py, tests/unit/executor/test_single_noblock.py		 Test methods renamed from generic identifiers to scenario-specific names describing block allocation mode, core counts, cache behavior, and dependency handling.
Scheduler test renames and info assertions
tests/unit/standalone/interactive/test_spawner.py		 TestCase classes and many test methods renamed to scheduler-focused names; test_meta/test_meta_step replaced by test_block_allocation_task_scheduler_info and test_one_process_task_scheduler_info which assert scheduler info fields like max_workers and max_cores.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • pyiron/executorlib#464: Related test renames around “no block allocation” with/without dependencies that align with changes in tests/unit/executor/test_single_noblock.py.

Poem

🐰
I hopped through tests to change a name,
Each method clearer, not a single blame.
Logic untouched, assertions still bright,
New names now guide the reviewer’s sight.
A tiny hop for cleaner test light.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'rename tests' is vague and generic, lacking specificity about which tests are being renamed or why, making it unclear what the main change accomplishes. Replace with a more descriptive title that specifies the refactoring scope, such as 'Rename test methods to reflect scheduler implementations' or 'Refactor test naming for clarity on executor configurations'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rename_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.19%. Comparing base (4396b94) to head (acc6a24).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files          39       39           
  Lines        2103     2103           
=======================================
  Hits         1981     1981           
  Misses        122      122

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen
jan-janssen merged commit a75059a into main Jun 10, 2026
61 of 65 checks passed
@jan-janssen
jan-janssen deleted the rename_tests branch June 10, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jan-janssen